Am I affected?

type your oidcc version to check

Description

Improper Verification of Cryptographic Signature vulnerability in erlef oidcc allows an unauthenticated attacker to impersonate an arbitrary user via an encrypted ID token or JARM response carrying no nested signature. OpenID Connect Core 1.0 section 2 requires that an encrypted ID token be signed then encrypted, with the result being a Nested JWT, and JARM processing rule 5 requires the client to check the signature unconditionally. oidcc instead accepted a JWE wrapping unsigned claims as fully validated, so anyone holding the relying party's public encryption key could mint a token with an arbitrary sub, iss, and aud without possessing the provider's signing key.

In oidcc_jwt_util:verify_decrypted_token/4, a decrypted payload that is not a signed JWS fell back to parsing the plaintext claims and returning them with no verifying key. oidcc_token:int_validate_jwt/4 then matched on the JOSE structure type rather than on whether a signature had been verified, and returned success. The JARM path in oidcc_token:validate_jarm/3 is reachable through the browser front channel. UserInfo responses are not affected, because OpenID Connect Core 1.0 section 5.3.2 permits them to be encrypted without also being signed.

This issue affects oidcc: from 3.2.0-beta.1 before 3.9.0.

Weaknesses & attack patterns

Weakness

CWE-347 · Improper Verification of Cryptographic Signature in catalog → MITRE ↗

Attack patterns

CAPEC-475 · Signature Spoofing by Improper Validation MITRE ↗

Affected — Hex / oidcc Hex.pm ↗ Repository ↗

3.2.0-beta.1 < 3.9.0 affected
every other version: unaffected
cpe cpe:2.3:a:erlef:oidcc:*:*:*:*:*:*:*:*
modules · source files · routines
modules oidcc_jwt_util · oidcc_token
source files src/oidcc_jwt_util.erl · src/oidcc_token.erl
routines oidcc_jwt_util:verify_decrypted_token/4 · oidcc_jwt_util:verify_not_none_alg/1 · oidcc_token:int_validate_jwt/4 · oidcc_token:validate_id_token/3 · oidcc_token:validate_jarm/3

Affected — GitHub / erlef/oidcc Repository ↗

37a1361 < 5f62fbc affected
every other version: unaffected
cpe cpe:2.3:a:erlef:oidcc:*:*:*:*:*:*:*:*
modules · source files · routines
modules oidcc_jwt_util · oidcc_token
source files src/oidcc_jwt_util.erl · src/oidcc_token.erl
routines oidcc_jwt_util:verify_decrypted_token/4 · oidcc_jwt_util:verify_not_none_alg/1 · oidcc_token:int_validate_jwt/4 · oidcc_token:validate_id_token/3 · oidcc_token:validate_jarm/3

Configurations

Reachable only when the OpenID Provider advertises ID token encryption (id_token_encryption_alg_values_supported and id_token_encryption_enc_values_supported), or, for the JARM path, authorization response encryption (authorization_encryption_alg_values_supported and authorization_encryption_enc_values_supported), and the relying party has an encryption key configured. Without those, decryption fails before the affected code is reached.

References

Credits

EQSTLab Reporter
Jonatan Männchen / EEF Remediation developer Coordinator

CVSS breakdown

CVSS:4.0/AV:N/AC:L/AT:P/PR:N/UI:P/VC:H/VI:H/VA:N/SC:N/SI:N/SA:N
« All CVEs